Make new palm flesh the default palm for Hands E and G (lite)#844
Merged
dg-shadow merged 8 commits intonoetic-develfrom Jan 9, 2025
Merged
Conversation
…and 'robot_description_semantic' parameters exists at node launch
…t_for_hands_e_and_g
niko-holmes
reviewed
Dec 10, 2024
niko-holmes
approved these changes
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## noetic-devel #844 +/- ##
=============================================
Coverage 40.19% 40.19%
=============================================
Files 13 13
Lines 1555 1555
Branches 637 637
=============================================
Hits 625 625
Misses 647 647
Partials 283 283
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
toliver
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Make new hand versions (with new palm flesh) the default versions for Hands E and G (lite), respectively, versions E4 and G4.
Also, renaming node
error_reporternode tounderactuation_error_reporterfor clarity purposes and ensuring parametersrobot_descriptionandrobot_description_semanticsare discoverable before starting the node.Update: This PR also now introduces fixes to some of our ROS tests (specifically, those invoking the method move_group.compute_cartesian_path() ), so that they now conform with the latest API changes to moveit_commander:
moveit/moveit#3618
Specifically, the argument
jump_thresholdhas now been deprecated, and, therefore, had to be removedChecklist
Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.
Tests
Documentation