Update the heartbeat log search string#96
Merged
stevenengler merged 1 commit intoshadow:mainfrom Mar 31, 2023
Merged
Conversation
robgjansen
approved these changes
Mar 31, 2023
stevenengler
added a commit
to stevenengler/shadow
that referenced
this pull request
Apr 14, 2023
Tornettools shouldn't search for this string anymore as of shadow/tornettools#96.
stevenengler
added a commit
to stevenengler/shadow
that referenced
this pull request
Apr 17, 2023
Tornettools shouldn't search for this string anymore as of shadow/tornettools#96.
stevenengler
added a commit
to shadow/shadow
that referenced
this pull request
Apr 17, 2023
Tornettools shouldn't search for this string anymore as of shadow/tornettools#96. Part of the 3.0 changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would search the log file for the string "_manager_heartbeat", but now we search for "[Pp]rocess resource usage at simtime" instead.
From the "Run all steps" CI test output, the "resource_usage.json" file shows data for the "run_time" field, so I think this code is still working correctly.