Merged
Conversation
I believe this fixes the root cause of shadow#3654
This fixes undefined behavior, though I'm not aware of us having hit it in practice.
This fixes undefined behavior, though I'm not aware of us having hit in practice.
Contributor
Author
|
Locally tested a release build using rust 1.89.0, first reproducing #3654 and then verifying that adding the missing clobbers in the shim's |
stevenengler
approved these changes
Sep 25, 2025
Contributor
stevenengler
left a comment
There was a problem hiding this comment.
Nice find!! I can confirm that the tests pass for me when using this branch built with RUSTUP_TOOLCHAIN=1.89 ./setup build --test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3654