Merged
Conversation
Contributor
Author
|
I had tried adding a determinism test that checksums the contents of < 7ffff71df000-7ffff79df000 rw-s 00000000 00:1e 126629 /dev/shm/shadow_shmemfile_701540.832816749-1656503
---
> 7ffff71df000-7ffff79df000 rw-s 00000000 00:1e 126630 /dev/shm/shadow_shmemfile_701540.931295999-1656567It might be nice to still write a test that "checksums all of the contents of /proc/maps except for shadow_shmemfile lines" or better yet add a more specialized |
robgjansen
requested changes
Jun 26, 2025
Remap /proc/self/* paths to point to the correct native path. Notably this fixes behavior for reading `/proc/self/maps`, which the rust runtime does, and for reading `/proc/self/exe` which asan does. Log a warning when opening proc files that we haven't specifically tested, thought about, or otherwise vetted. Fixes shadow#3541 Fixes shadow#3536 Progress on shadow#2790
sporksmith
added a commit
to sporksmith/shadow
that referenced
this pull request
Jun 26, 2025
sporksmith
added a commit
to sporksmith/shadow
that referenced
this pull request
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remap /proc/self/* paths to point to the correct native path. Notably this fixes behavior for reading
/proc/self/maps, which the rust runtime does, and for reading/proc/self/exewhich asan does.Log a warning when opening proc files that we haven't specifically tested, thought about, or otherwise vetted.
Progress on #3541
Fixes #3536
Progress on #2790