Make AT_RANDOM in the linux auxiliary vector deterministic#3542
Merged
sporksmith merged 10 commits intoshadow:mainfrom Mar 30, 2025
Merged
Make AT_RANDOM in the linux auxiliary vector deterministic#3542sporksmith merged 10 commits intoshadow:mainfrom
sporksmith merged 10 commits intoshadow:mainfrom
Conversation
Regression test for shadow#3539. (Currently fails; fixed in next commit)
Confirmed this fixes the determinism test and therefore shadow#3539. Some quick initial tests appear to confirm this also fixes shadow#2693 and *completely* deterministic strace file.
stevenengler
approved these changes
Mar 29, 2025
We don't want to introduce more libc dependencies in the shim (https://github.com/shadow/shadow/milestone/54). Instead of using `libc::getauxval`, we can read `/proc/self/auxv`.
The string "at_random" is intended to correspond to the linux and libc constant `AT_RANDOM`, but is a bit confusing. I think the `AT_` anyways stands for something like "auxvec tag".
Wasn't able to squash these onto the relevant earlier commits due to the file rename.
zydou
pushed a commit
to zydou/arti
that referenced
this pull request
Apr 1, 2025
Bump to today's latest - 24343d0ef1da38e2e9fe6684bdffe3cf32c1153d. Primarily to get determinism fix shadow/shadow#3542.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3539, and progress (maybe completion?) on #2693 and #3538.