Conversation
25f195c to
a5eeadf
Compare
|
I don't think this requires a version bump because tracker output was put into the experimental section and thus we can change it at any time. |
|
Not sure if dropping the tracker is controversial or not; happy to have @sporksmith weigh in too. AFAIK, the log lines and information that are dropped are not used in any of the tornettools parsing. Tornettools does call the tgen plotting scripts, and it has some of its own plotting, but I don't think it uses the tracker info. HOWEVER, I just realized that tracker output is currently being parsed and plotted in our nightly/weekly benchmark processes. For example:
The above produces graphs like this: I think we're just using these tracker-related scripts because they existed, but I don't think they are particularly helpful, especially since we already have other tgen or tornettools plots that are more helpful. So I don't think the fact that we are running them in the benchmarks is a good enough argument to prevent further progress on c migration. |
Are the other files in that directory all coming from |
I linked to an example from the tgen nightly, and the other plots in that directory are coming from running https://github.com/shadow/benchmark-results/tree/master/tor/2024-11-27-T04-14-19/plots In the above output, I think the only file that we would need to remove if we merge this PR is |
stevenengler
left a comment
There was a problem hiding this comment.
Removing the tracker sounds good to me! I agree that we'll need to remove the shadow.results.pdf and everything that generates it from the benchmark repo. That change will probably need to be done first so that the benchmark CI doesn't break.
This should probably also have a changelog entry even though it's experimental.
|
Removed tracker data from benchmarks |
The tools were used to parse and plot Shadow log files, including information logged by the now-removed tracker and other log file information (e.g., rusage() output). The tracker is removed, and in general Shadow no longer supports users parsing information from the log files, so the parsing tools are being removed too.
a5eeadf to
c17f90a
Compare
The tracker is C code that is blocking converting other modules such as DNS to rust cleanly. We previously decided that we would no longer support the C tracker code, and that new statistics should be handled in rust and logged to data files rather than the log file.
Closes #800, #1399
Progress on #1450, #1719
Stats planning: #2727