Skip to content

Remove unused countdown latch#2720

Merged
robgjansen merged 2 commits intoshadow:mainfrom
robgjansen:remove-unused-c
Feb 6, 2023
Merged

Remove unused countdown latch#2720
robgjansen merged 2 commits intoshadow:mainfrom
robgjansen:remove-unused-c

Conversation

@robgjansen
Copy link
Copy Markdown
Member

@robgjansen robgjansen commented Feb 3, 2023

Also forgot to remove Dockerfile in #2719

@robgjansen robgjansen added this to the Code health and maintenance milestone Feb 3, 2023
@robgjansen robgjansen self-assigned this Feb 3, 2023
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Feb 3, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2023

Codecov Report

Base: 67.03% // Head: 68.30% // Increases project coverage by +1.26% 🎉

Coverage data is based on head (952d9d9) compared to base (6064cc8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
+ Coverage   67.03%   68.30%   +1.26%     
==========================================
  Files         203      203              
  Lines       30513    30513              
  Branches     5970     5970              
==========================================
+ Hits        20454    20841     +387     
+ Misses       5375     4955     -420     
- Partials     4684     4717      +33     
Flag Coverage Δ
tests 68.30% <ø> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib/shmem/src/scmutex.rs 87.05% <0.00%> (-2.36%) ⬇️
src/main/utility/byte_queue.rs 56.01% <0.00%> (ø)
src/main/core/support/configuration.rs 76.14% <0.00%> (+0.16%) ⬆️
src/lib/shadow-shim-helper-rs/src/signals.rs 72.28% <0.00%> (+0.60%) ⬆️
src/main/core/support/units.rs 56.62% <0.00%> (+0.77%) ⬆️
src/main/host/syscall/handler/socket.rs 67.10% <0.00%> (+0.88%) ⬆️
src/main/host/descriptor/mod.rs 68.29% <0.00%> (+1.21%) ⬆️
src/main/core/manager.rs 64.74% <0.00%> (+1.55%) ⬆️
src/main/host/process.rs 79.49% <0.00%> (+1.56%) ⬆️
src/main/host/memory_manager/mod.rs 67.74% <0.00%> (+1.61%) ⬆️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robgjansen robgjansen merged commit 879ba59 into shadow:main Feb 6, 2023
@robgjansen robgjansen deleted the remove-unused-c branch February 7, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants