Skip to content

Remove docker bits since we don't support it#2719

Merged
robgjansen merged 1 commit intoshadow:mainfrom
robgjansen:remove-docker
Feb 3, 2023
Merged

Remove docker bits since we don't support it#2719
robgjansen merged 1 commit intoshadow:mainfrom
robgjansen:remove-docker

Conversation

@robgjansen
Copy link
Copy Markdown
Member

@robgjansen robgjansen commented Feb 3, 2023

No description provided.

@robgjansen robgjansen added this to the Code health and maintenance milestone Feb 3, 2023
@robgjansen robgjansen self-assigned this Feb 3, 2023
@github-actions github-actions bot added Component: Documentation In-repository documentation, under docs/ Component: Testing Unit and integration tests and frameworks labels Feb 3, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2023

Codecov Report

Base: 68.22% // Head: 68.17% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (01ea88b) compared to base (520184d).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2719      +/-   ##
==========================================
- Coverage   68.22%   68.17%   -0.05%     
==========================================
  Files         203      203              
  Lines       30513    30513              
  Branches     5970     5970              
==========================================
- Hits        20817    20802      -15     
- Misses       4986     4987       +1     
- Partials     4710     4724      +14
Flag Coverage Δ
tests 68.17% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/utility/shm_cleanup.rs 59.09% <0.00%> (-5.69%) ⬇️
src/main/core/logger/shadow_logger.rs 69.61% <0.00%> (-2.77%) ⬇️
src/lib/shmem/src/scmutex.rs 87.05% <0.00%> (-2.36%) ⬇️
src/main/host/descriptor/descriptor_table.rs 71.68% <0.00%> (-1.77%) ⬇️
src/main/host/syscall/handler/socket.rs 66.00% <0.00%> (-1.55%) ⬇️
src/main/host/syscall/handler/fcntl.rs 59.15% <0.00%> (-1.41%) ⬇️
src/main/core/main.rs 39.13% <0.00%> (-1.25%) ⬇️
src/main/network/relay/mod.rs 82.35% <0.00%> (-1.18%) ⬇️
src/main/host/descriptor/eventfd.rs 64.64% <0.00%> (-1.02%) ⬇️
src/test/futex/test_futex.c 64.00% <0.00%> (-0.89%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robgjansen robgjansen requested a review from sporksmith February 3, 2023 22:42
@robgjansen robgjansen merged commit 6064cc8 into shadow:main Feb 3, 2023
@robgjansen robgjansen deleted the remove-docker branch February 3, 2023 22:51
@robgjansen robgjansen mentioned this pull request Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@robgjansen robgjansen

Labels

Component: Documentation In-repository documentation, under docs/ Component: Testing Unit and integration tests and frameworks

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

2 participants

@robgjansen @sporksmith