Merged
Conversation
This makes it clearer to the caller that they need to be careful to avoid conflicting borrows when using such APIs.
This a borrow in one of these methods fails at runtime, this annotation causes the panic to identify the caller, which is more likely where the real issue is.
Codecov ReportBase: 67.54% // Head: 68.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
==========================================
+ Coverage 67.54% 68.19% +0.64%
==========================================
Files 200 200
Lines 29509 29522 +13
Branches 5789 5791 +2
==========================================
+ Hits 19933 20132 +199
+ Misses 4993 4779 -214
- Partials 4583 4611 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
robgjansen
approved these changes
Dec 20, 2022
Member
robgjansen
left a comment
There was a problem hiding this comment.
Nit: I think you want the extended commit message of bd643c1 to start with "When" instead of "This".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to @stevenengler's feedback on #2612.
#[track_caller]to borrowing APIs