Make the Rust Process own the C Process#2612
Merged
sporksmith merged 10 commits intoshadow:mainfrom Dec 20, 2022
Merged
Conversation
Codecov ReportBase: 68.01% // Head: 67.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
- Coverage 68.01% 67.89% -0.12%
==========================================
Files 200 200
Lines 29278 29512 +234
Branches 5755 5789 +34
==========================================
+ Hits 19912 20037 +125
- Misses 4770 4878 +108
- Partials 4596 4597 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9b280f7 to
91d6d7c
Compare
stevenengler
approved these changes
Dec 20, 2022
a9e9bf4 to
df8e2ed
Compare
At this step, compiles but crashes at runtime due to recursive mut borrows of Process.
To avoid recursive borrow problems, we'll for now need to *not* have a mutable borrow of Process for the whole duration of syscalls, since legacy C code needs to try to borrow again. For that to work, we need to make Process's mut methods be non-mut, which means we need interior mutability. To implement interior mutability we need to move corresponding objects into the Rust Process.
df8e2ed to
1cfe4d4
Compare
Having a mix of calling DescriptorTable methods through Process and borrowing the whole DescriptorTable led to borrow conflicts.
1cfe4d4 to
513a9af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.