Skip to content

Host::add_application: take Rust objects and remove unsafe#2583

Merged
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:host-add-application
Dec 1, 2022
Merged

Host::add_application: take Rust objects and remove unsafe#2583
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:host-add-application

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith commented Nov 30, 2022

No description provided.

@sporksmith sporksmith enabled auto-merge (squash) November 30, 2022 22:23
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Nov 30, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 30, 2022 •
edited
Loading

Codecov Report

Base: 67.74% // Head: 67.74% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d1e086b) compared to base (45d1ac6).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d1e086b differs from pull request most recent head 2644823. Consider uploading reports for the commit 2644823 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2583   +/-   ##
=======================================
  Coverage   67.74%   67.74%           
=======================================
  Files         195      195           
  Lines       29025    29029    +4     
  Branches     5705     5708    +3     
=======================================
+ Hits        19663    19666    +3     
+ Misses       4813     4809    -4     
- Partials     4549     4554    +5
Flag Coverage Δ
tests 67.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/manager.rs 63.69% <100.00%> (-0.56%) ⬇️
src/main/host/host.rs 83.27% <100.00%> (+0.31%) ⬆️
src/main/core/scheduler/pools/unbounded.rs 77.90% <0.00%> (-4.07%) ⬇️
src/main/utility/shm_cleanup.rs 59.55% <0.00%> (-2.25%) ⬇️
src/main/host/memory_manager/memory_copier.rs 73.33% <0.00%> (-2.23%) ⬇️
src/main/host/descriptor/pipe.rs 85.44% <0.00%> (-0.64%) ⬇️
src/test/signal/test_signals.rs 84.34% <0.00%> (-0.36%) ⬇️
src/main/utility/interval_map.rs 79.84% <0.00%> (ø)
src/lib/shadow-shim-helper-rs/src/lib.rs 75.00% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sporksmith
Copy link
Copy Markdown
Contributor Author

sporksmith commented Dec 1, 2022

This change is also included in #2584 ; up to you whether to review this separately or not

@sporksmith sporksmith force-pushed the host-add-application branch from d1e086b to 2644823 Compare December 1, 2022 15:05
@sporksmith sporksmith merged commit 31256a4 into shadow:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@sporksmith sporksmith

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Convert existing modules to Rust

Development

Successfully merging this pull request may close these issues.

2 participants

@sporksmith @stevenengler