Skip to content

Move process list to Rust Host and delete HostCInternal#2584

Merged
sporksmith merged 6 commits intoshadow:mainfrom
sporksmith:host-processes
Dec 1, 2022
Merged

Move process list to Rust Host and delete HostCInternal#2584
sporksmith merged 6 commits intoshadow:mainfrom
sporksmith:host-processes

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith commented Dec 1, 2022

No description provided.

@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Dec 1, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2022 •
edited
Loading

Codecov Report

Base: 67.36% // Head: 66.84% // Decreases project coverage by -0.52% ⚠️

Coverage data is based on head (fc34c5f) compared to base (31256a4).
Patch coverage: 70.83% of modified lines in pull request are covered.

❗ Current head fc34c5f differs from pull request most recent head 9d2244e. Consider uploading reports for the commit 9d2244e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2584      +/-   ##
==========================================
- Coverage   67.36%   66.84%   -0.53%     
==========================================
  Files         195      195              
  Lines       29028    29056      +28     
  Branches     5705     5719      +14     
==========================================
- Hits        19555    19422     -133     
- Misses       4940     5100     +160     
- Partials     4533     4534       +1
Flag Coverage Δ
tests 66.84% <70.83%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/process.rs 64.51% <42.85%> (-8.37%) ⬇️
src/main/host/host.rs 80.45% <69.64%> (-2.13%) ⬇️
src/main/core/manager.rs 63.69% <100.00%> (ø)
src/main/host/syscall/handler/time.rs 0.00% <0.00%> (-58.54%) ⬇️
src/main/host/descriptor/pipe.rs 58.86% <0.00%> (-25.95%) ⬇️
src/main/host/timer.rs 87.90% <0.00%> (-9.68%) ⬇️
src/main/host/syscall/handler/unistd.rs 50.21% <0.00%> (-6.87%) ⬇️
src/main/utility/stream_len.rs 38.09% <0.00%> (-4.77%) ⬇️
src/main/host/memory_manager/memory_mapper.rs 66.66% <0.00%> (-4.77%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sporksmith sporksmith mentioned this pull request Dec 1, 2022
Merged
stevenengler
stevenengler approved these changes Dec 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sporksmith sporksmith enabled auto-merge December 1, 2022 18:03
@sporksmith sporksmith merged commit 5b73467 into shadow:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@sporksmith sporksmith

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Convert existing modules to Rust

Development

Successfully merging this pull request may close these issues.

2 participants

@sporksmith @stevenengler