Add sched_yield calls in thread_ptrace#1127
Merged
sporksmith merged 2 commits intoshadow:devfrom Feb 27, 2021
Merged
Conversation
sporksmith
added a commit
to sporksmith/shadow
that referenced
this pull request
Feb 26, 2021
This gives the plugin a chance to run before checking whether it's stopped again. This prevents deadlock in ptrace's "hybrid spin" when using --pin-cpus and --sched-fifo together, and helps performance in other cases. Progress on shadow#1127
c46dce5 to
f2ec08f
Compare
This gives the plugin a chance to run before checking whether it's stopped again. This prevents deadlock in ptrace's "hybrid spin" when using --pin-cpus and --sched-fifo together, and helps performance in other cases. Progress on shadow#1041
f2ec08f to
dbeaca8
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1127 +/- ##
==========================================
- Coverage 55.96% 55.95% -0.01%
==========================================
Files 136 136
Lines 20075 20077 +2
Branches 4770 4770
==========================================
Hits 11235 11235
Misses 5995 5995
- Partials 2845 2847 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
16 tasks
robgjansen
approved these changes
Feb 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the plugin a chance to run before checking whether it's
stopped again. This prevents deadlock in ptrace's "hybrid spin" when
using --pin-cpus and --sched-fifo together, and helps performance in
other cases.