Add llama embedding modules [unreachable code] - step 1/3#983
Merged
Conversation
8d28b75 to
39b7e48
Compare
merrymercy
approved these changes
Aug 8, 2024
merrymercy
reviewed
Aug 8, 2024
39b7e48 to
c820592
Compare
This was referenced Aug 8, 2024
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Step 1 for supporting e5-mistral embedding model.
Modification
This PR add the modules for
e5-mistralembedding model. The changes are unreachable. Connecting changes will come up in followup PRs.Checklist
pre-commit run --all-filesor other linting tools are used to fix potential lint issues.