Add option to disable any_whitespace for xgrammar and llguidance backends.#8919
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @lulor, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new server argument that provides granular control over whitespace handling in constrained JSON generation for the xgrammar and llguidance backends. My aim is to allow users to enforce a more compact JSON representation by disabling flexible whitespace, which can be beneficial for specific parsing requirements or reducing output size.
Highlights
- New Server Argument: A new command-line argument,
--constrained-json-disable-any-whitespace, has been added toServerArgs, allowing users to control whether flexible whitespace is permitted in constrained JSON output. - XGrammar Backend Integration: The
XGrammarGrammarBackendnow accepts anany_whitespaceparameter during initialization, which is then passed to the grammar compiler when generating JSON schemas, enabling more control over whitespace in the output. - LLGuidance Backend Integration: The
GuidanceBackendhas been updated to incorporate theany_whitespaceparameter in its constructor and utilizes this setting when dispatching JSON schemas, influencing the flexibility of whitespace in the generated JSON. - Whitespace Pattern Type Correction: The type hint for the
whitespace_patternparameter in theOutlinesGrammarBackend's constructor has been corrected frombooltostr | None, improving type accuracy.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces an option to disable flexible whitespace in JSON-constrained generation for the xgrammar and llguidance backends. The changes are well-implemented and consistent across the affected files. My main feedback is to improve the naming of the new server argument for better clarity and maintainability. I've provided suggestions to rename constrained_json_disable_any_whitespace to constrained_json_compact.
|
@lulor Thank you for this change. Can you take a look at the lint error? |
|
@CatherineSue thank you for pushing this forward. I believe the lint check is passing now, is there anything I can do on my side? |
|
@lulor All good right now. I'm waiting for the CI to finish. If it passes, we'll merge. |
|
ci was successful |
…` backends. (sgl-project#8919) Co-authored-by: Chang Su <chang.s.su@oracle.com>
Motivation
See #8250.
Modifications
This PR simply adds a server arg which is passed through to the
xgrammarandllguidancebackends, preserving the current defaults.Accuracy Test
Benchmark & Profiling
Checklist