Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
ispobock
reviewed
Aug 6, 2025
| ) | ||
|
|
||
| def forward(self, hidden_states: torch.Tensor, topk_output: StandardTopKOutput): | ||
| og_hidden_states = hidden_states.shape[-1] |
Collaborator
There was a problem hiding this comment.
what is og_hidden_states? can we make it more clear?
Collaborator
Author
There was a problem hiding this comment.
origin_hidden_states_dim, renamed.
Collaborator
Author
There was a problem hiding this comment.
Must do padding here because the trl-llm kernel limit
fzyzcjy
added a commit
to fzyzcjy/sglang
that referenced
this pull request
Aug 7, 2025
This reverts commit 4373df5. # Conflicts: # python/sglang/srt/server_args.py
fzyzcjy
added a commit
to fzyzcjy/sglang
that referenced
this pull request
Aug 7, 2025
This reverts commit 4373df5. # Conflicts: # python/sglang/srt/layers/moe/fused_moe_triton/layer.py # python/sglang/srt/layers/quantization/mxfp4.py # python/sglang/srt/server_args.py
narutolhy
pushed a commit
to narutolhy/sglang
that referenced
this pull request
Aug 17, 2025
MahmoudAshraf97
pushed a commit
to MahmoudAshraf97/sglang
that referenced
this pull request
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Accuracy Test
Benchmark & Profiling
Checklist