Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @zhyncs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've introduced support for CUDA 12.9 into the sgl-kernel build system. This change primarily updates the build.sh script to correctly configure the build environment and PyTorch installation for systems utilizing CUDA 12.9, ensuring compatibility and enabling development with the latest CUDA version.
Highlights
- CUDA 12.9 Build Support: The build script
sgl-kernel/build.shhas been updated to recognize and handle CUDA version 12.9. This involves adding a newelifcondition that sets theDOCKER_IMAGEandTORCH_INSTALLvariables specifically for CUDA 12.9, pointing to thecu129PyTorch test wheel.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to add support for CUDA 12.9. The change in build.sh is a good first step. I've added a review comment with a suggestion to refactor the conditional logic for setting TORCH_INSTALL, which will improve code clarity and make it easier to add support for future CUDA versions.
However, there is a critical omission. The sgl-kernel/rename_wheels.sh script, which is responsible for creating CUDA-specific wheel names, has not been updated. It contains a hardcoded check for CUDA 12.8 and will not work for 12.9. This will lead to incorrectly named wheels for CUDA 12.9 builds, defeating the purpose of this PR. Please update rename_wheels.sh to correctly handle CUDA 12.9 and consider making it more robust for future versions, for example by using the CUDA_VERSION environment variable.
Motivation
Modifications
Accuracy Test
Benchmark & Profiling
Checklist