Support Phi-4 Multi-Modal (text + vision only)#6494
Merged
zhyncs merged 12 commits intosgl-project:mainfrom May 25, 2025
Merged
Support Phi-4 Multi-Modal (text + vision only)#6494zhyncs merged 12 commits intosgl-project:mainfrom
zhyncs merged 12 commits intosgl-project:mainfrom
Conversation
Collaborator
mickqian
reviewed
May 23, 2025
Collaborator
|
Better to be merged after #4969 , due to some change to the omni model processing and testing |
Collaborator
Author
Hi @mickqian, thank you so much for reviewing my PR :) Can you share more details about the concern you have such that I can test them locally? JFYI, I was able to merge your branch mickqian:qwen2.5-omni locally without conflict and get a green TestOpenAIVisionServer run for phi4mm. |
Collaborator
I just noticed audio input is not supported this time. |
mickqian
reviewed
May 23, 2025
mickqian
approved these changes
May 25, 2025
zhyncs
approved these changes
May 25, 2025
6 tasks
Layssy
pushed a commit
to Layssy/sglang-iaas
that referenced
this pull request
Jun 9, 2025
xwu-intel
pushed a commit
to xwu-intel/sglang
that referenced
this pull request
Jun 17, 2025
67 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Support Phi4-MM model with text + vision.
Modifications
This change introduced the basic text + image support.
It's worth noting that the current MMMU run (without LoRA) is lower than advertised because Phi4MM relies on LoRA for full image understanding capabilities. However, LoRA support requires refactoring / generalizing the existing SGL LoRA handling, which will hopefully be addressed in this separate PR: #6585
Example: degraded image understanding without LoRA (MMMU is only 38). As comparison in our local branch (#6585) with LoRA, MMMU is boosted to ~50:
TODO in this PR:
TODO in follow-up PR (ordered by priority):
Tracked in #6544
Checklist