[Fix] Address remaining issues of supporting MiniCPMV#2977
Merged
zhaochenyang20 merged 1 commit intosgl-project:mainfrom Jan 28, 2025
Merged
[Fix] Address remaining issues of supporting MiniCPMV#2977zhaochenyang20 merged 1 commit intosgl-project:mainfrom
zhaochenyang20 merged 1 commit intosgl-project:mainfrom
Conversation
3 tasks
d4a7a2d to
d32da67
Compare
Collaborator
|
Great work! Once ready, please ask us to review. |
Contributor
|
also remove these vllm dependency sglang/python/sglang/srt/layers/attention/vision.py Lines 8 to 9 in 2584f6d |
6f78efe to
797ac44
Compare
mickqian
commented
Jan 24, 2025
Collaborator
|
@mickqian mick, great work. So we are ended and just need to past the review? Thanks! |
b09c28b to
bee8340
Compare
Collaborator
|
@mickqian there are still some failed cases, but it seems they are not related to your pr? |
Collaborator
Yeah. CI is wrong possibly due to kernel or largely refactor. |
Collaborator
Since |
yizhang2077
approved these changes
Jan 25, 2025
zhyncs
reviewed
Jan 25, 2025
3 tasks
1985fb0 to
2efd389
Compare
5 tasks
6 tasks
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Address remaining issues of #2785
Modifications
Checklist