Skip to content

[PP][Bugfix] Handle input_ids assignment in prepare_for_extend#26883

Merged
ShangmingCai merged 3 commits into
mainfrom
pp-profiler-bugfix
Jun 1, 2026
Merged

[PP][Bugfix] Handle input_ids assignment in prepare_for_extend#26883
ShangmingCai merged 3 commits into
mainfrom
pp-profiler-bugfix

Conversation

@ShangmingCai

@ShangmingCai ShangmingCai commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Fix CPP bug (missing change of PR: #25945)

  • Add handling for deferred H2D in prepare_for_extend

Modifications

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ❌ Run #26738479540
Latest PR Test (Extra): ❌ Run #26738479492

Add handling for deferred H2D in prepare_for_extend
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@ShangmingCai

Copy link
Copy Markdown
Collaborator Author

/rerun-test registered/disaggregation/test_disaggregation_pp.py

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Results for /rerun-test registered/disaggregation/test_disaggregation_pp.py:

🚀 8-gpu-h20 (1 test): ✅ View workflow run

cd test/ && python3 registered/disaggregation/test_disaggregation_pp.py

@ShangmingCai

Copy link
Copy Markdown
Collaborator Author

CI has passed now:
image

@ShangmingCai ShangmingCai merged commit afd2d0b into main Jun 1, 2026
87 of 99 checks passed
@ShangmingCai ShangmingCai deleted the pp-profiler-bugfix branch June 1, 2026 06:43
monkeyLoveding pushed a commit to monkeyLoveding/sglang_open that referenced this pull request Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant