Skip to content

fix: rename mimo spec threshold attr to num_accepted_drafts_thres#24118

Merged
hnyls2002 merged 1 commit intomainfrom
lsyin/fix-mimo-spec-thres
Apr 30, 2026
Merged

fix: rename mimo spec threshold attr to num_accepted_drafts_thres#24118
hnyls2002 merged 1 commit intomainfrom
lsyin/fix-mimo-spec-thres

Conversation

@hnyls2002
Copy link
Copy Markdown
Collaborator

Follow-up to #23962: SpecDecodingMixin was renamed from accept_length_thres to num_accepted_drafts_thres, but TestMiMoV2Flash still set the old name. Causes AttributeError on stage-c-test-8-gpu-h200.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@hnyls2002
Copy link
Copy Markdown
Collaborator Author

/rerun-test test_mimo_models.py

@github-actions
Copy link
Copy Markdown
Contributor

8-gpu-h200 (1 test): View workflow run

cd test/ && python3 registered/8-gpu-models/test_mimo_models.py

@hnyls2002
Copy link
Copy Markdown
Collaborator Author

hnyls2002 commented Apr 30, 2026

/tag-and-rerun-test

@hnyls2002 hnyls2002 merged commit c54ada9 into main Apr 30, 2026
64 of 70 checks passed
@hnyls2002 hnyls2002 deleted the lsyin/fix-mimo-spec-thres branch April 30, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant