[CI] Fix black formatting on main (unblocks PR #21247 lint)#24093
Merged
Kangyan-Zhou merged 1 commit intosgl-project:mainfrom Apr 29, 2026
Merged
[CI] Fix black formatting on main (unblocks PR #21247 lint)#24093Kangyan-Zhou merged 1 commit intosgl-project:mainfrom
Kangyan-Zhou merged 1 commit intosgl-project:mainfrom
Conversation
Three files on main currently fail the black-jupyter pre-commit hook, which breaks lint CI for any PR that rebases on or merges with main (e.g., sgl-project#21247). Run black 26.1.0 on the affected files to restore conformance — no behavioral changes, formatting only. Files reformatted: - python/sglang/srt/model_executor/model_runner.py - python/sglang/srt/model_loader/loader.py - python/sglang/srt/server_args.py Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
vguduruTT
pushed a commit
to vguduruTT/sglang
that referenced
this pull request
May 2, 2026
sgl-project#24093) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
black(26.1.0, version pinned in.pre-commit-config.yaml) on three files where the formatting onmainno longer matches whatblack-jupyterproduces. No behavioral changes, formatting only.python/sglang/srt/model_executor/model_runner.py,python/sglang/srt/model_loader/loader.py,python/sglang/srt/server_args.py.Why
The
lintjob runspre-commit run --all-filesand currently fails onmainfor these three files. This breaks the lint check on every PR that builds againstmain, including the Torch 2.11 upgrade PR #21247 — see the failing run: https://github.com/sgl-project/sglang/actions/runs/25132074962/job/73660689648?pr=21247The diff produced by black here matches exactly what that CI run reported.
Test plan
pre-commit run black-jupyter --files <the 3 files>→ Passedpre-commit run --files <the 3 files>→ all hooks Passed🤖 Generated with Claude Code