Skip to content

[NPU] [DOC] Add support new models doc for NPU#23824

Merged
sglang-npu-bot merged 3 commits intosgl-project:mainfrom
amote-i:update_ascend_docs
Apr 27, 2026
Merged

[NPU] [DOC] Add support new models doc for NPU#23824
sglang-npu-bot merged 3 commits intosgl-project:mainfrom
amote-i:update_ascend_docs

Conversation

@amote-i
Copy link
Copy Markdown
Contributor

@amote-i amote-i commented Apr 27, 2026

Motivation

Add support new models doc for NPU

Modifications

N/A

Accuracy Tests

N/A

Speed Tests and Profiling

N/A

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@amote-i amote-i requested a review from wisclmy0611 as a code owner April 27, 2026 08:47
@github-actions github-actions Bot added the npu label Apr 27, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new documentation file, ascend_npu_support_new_models.mdx, which provides a detailed guide on supporting new language and multimodal models in SGLang, with a specific focus on Ascend NPU adaptations. The documentation includes implementation steps, porting guides from vLLM, and practical examples for external model registration. Review feedback identified a hardcoded line number in a source code link, a typo in the testing section, and a missing pp_proxy_tensors argument in a code example's forward method signature that would lead to a runtime error.

Comment thread docs_new/docs/hardware-platforms/ascend-npus/ascend_npu_support_new_models.mdx Outdated
@sglang-npu-bot sglang-npu-bot merged commit 06725ec into sgl-project:main Apr 27, 2026
42 checks passed
vguduruTT pushed a commit to vguduruTT/sglang that referenced this pull request May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants