Summary

PR #21482 ("Skip ci for .md files", merged 2026-03-28) introduced two different negation styles in the same change. It used the correct basename-level form for main_package and test:

"python/sglang/!(multimodal_gen)/**/!(*.md)"
"test/**/!(*.md)"

but used a broken extension-level form for sgl_kernel and multimodal_gen:

"sgl-kernel/**/*.!(md|txt)"
"python/sglang/multimodal_gen/**/*.!(md|ipynb)"

The extension-level form has two silent false-negative bugs:

1. Extensionless files don't match. The negation sits inside the extension (.!(md|txt)), so the filename must contain a literal .. Files like sgl-kernel/Dockerfile, sgl-kernel/Makefile, sgl-kernel/LICENSE, and (in multimodal_gen) any Dockerfile/Makefile/LICENSE never trip the filter. This caused [Dependency] Upgrade to Torch 2.11.0 #21247 (torch 2.11 bump) to skip sgl-kernel-build-wheels and hit an ABI mismatch against the pre-built PyPI sglang-kernel wheel (undefined symbol: _ZN3c104cuda29c10_cuda_check_implementationEiPKcS2_ib).
2. Blanket *.txt exclusion swallows CMakeLists.txt. sgl-kernel/CMakeLists.txt and sgl-kernel/csrc/cpu/CMakeLists.txt control the build (Triton tag, include paths, compile flags) and should absolutely trigger a rebuild. The exclusion was almost certainly intended only for THIRDPARTYNOTICES.txt.

Fix: rewrite the two broken filters at the basename level, matching the style already used for main_package / test:

sgl_kernel:
  - "sgl-kernel/**/!(*.md|THIRDPARTYNOTICES.txt|LICENSE)"
multimodal_gen:
  - "python/sglang/multimodal_gen/**/!(*.md|*.ipynb)"

A single extglob also sidesteps the dorny/paths-filter multi-! ordering bug that would otherwise force predicate-quantifier: 'every' and break OR-semantics with the other include patterns (issue #260). Keeping the negation intra-pattern also avoids any cross-filter side-effects in the same step.

Applied across all workflows that used the broken pattern:

• sgl_kernel filter: pr-test.yml, pr-test-amd.yml, pr-test-amd-rocm720.yml, pr-test-xeon.yml, pr-test-xpu.yml (5 files).
• multimodal_gen filter: pr-test.yml, pr-test-npu.yml, pr-test-amd.yml, pr-test-amd-rocm720.yml (4 files; pr-test.yml and pr-test-amd*.yml intersect the sgl_kernel set).

Test plan

Verified locally with picomatch@2.3.1 (the version dorny/paths-filter pins) invoked with {dot: true} (matching dorny/paths-filter/src/filter.ts:16). The test script reads the patterns straight from the committed workflow files, confirms all 5 sgl_kernel: and 4 multimodal_gen: blocks collapsed to the same two unique strings, and runs 19 + 13 = 32 cases — all pass.

sgl_kernel filter

multimodal_gen filter

Reproducer:

mkdir -p /tmp/dorny-test && cd /tmp/dorny-test
npm init -y && npm install picomatch@^2.3.1
node -e "console.log(require('picomatch')('sgl-kernel/**/!(*.md|THIRDPARTYNOTICES.txt|LICENSE)', {dot:true})('sgl-kernel/CMakeLists.txt'))"
# → true  (false with the old pattern)

Notes

• Exclusion scope. The basename-level excludes (LICENSE, THIRDPARTYNOTICES.txt, *.md, *.ipynb) apply at any depth under sgl-kernel/ or python/sglang/multimodal_gen/, not just top-level. Today the repo only has top-level occurrences, so this is observationally identical. If vendored code were ever added under e.g. sgl-kernel/3rdparty/<lib>/LICENSE, that would also be excluded — which is arguably the right behavior (vendored license metadata shouldn't trigger kernel rebuilds).
• Out of scope. This PR deliberately keeps the denylist style inherited from Skip ci for .md files #21482. A follow-up could switch sgl_kernel to an explicit allowlist of build-relevant extensions (.py, .cu, .cuh, .cpp, .h, .hpp, .sh, .toml, .cmake, .yml) plus explicit files (CMakeLists.txt, Dockerfile, Makefile). Trade-off is different (new build-relevant extensions would need explicit adds), so saving that for a separate discussion.

Checks

• pre-commit run clean on the six touched files
• Local picomatch tests read patterns directly from the six committed workflow files; 32 cases (19 sgl_kernel + 13 multimodal_gen) all pass, including nested files, dotfiles, hypothetical vendored LICENSE, and in-repo .claude/CLAUDE.md
• Grepped entire .github/ tree for remaining extension-level negation patterns — none left
• CI on this PR triggers sgl-kernel-build-wheels because the change touches workflow files (confirms filter is re-exercised end-to-end)

🤖 Generated with Claude Code