[diffusion] chore: auto-enable best parallel setting if unspecified#22763
Merged
[diffusion] chore: auto-enable best parallel setting if unspecified#22763
Conversation
When users launch with --num-gpus >= 2 without specifying any parallelism flags (--sp-degree, --ulysses-degree, --ring-degree, --enable-cfg-parallel), automatically enable CFG parallel instead of the previous default of pure sequence parallelism (ulysses). Benchmarked on H200 (2 GPU, warmup excluded): Qwen-Image 1024x1024: SP 11.21s / TP 13.43s / CFG 7.14s (-36%) Wan-1.3B T2V 480x832: SP 5.95s / CFG 4.77s (-20%) Wan-14B T2V 480x832: SP 23.75s / CFG 21.27s (-10%) Users can opt out by explicitly setting --sp-degree or --ulysses-degree. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users launch with
--num-gpus >= 2without specifying any parallelism flags (--sp-degree, --ulysses-degree, --ring-degree, --enable-cfg-parallel), automatically enable CFG parallel instead of the previous default of pure sequence parallelism (ulysses).Benchmarked on H200 (2 GPU, warmup excluded):
Users can opt out by explicitly setting --sp-degree or --ulysses-degree.
Motivation
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci