Rename _alive_streaming_session_count; use _is_streaming helper#22755
Merged
Rename _alive_streaming_session_count; use _is_streaming helper#22755
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
efff0ef to
bfa5ce0
Compare
Collaborator
Author
|
/rerun-test test_streaming_session.py |
Contributor
|
✅ |
hnyls2002
added a commit
that referenced
this pull request
Apr 15, 2026
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This is part of the streaming session memory accounting fix series (#22651). Stacked on #22753. All streaming session tests pass on H200 with strict busy check.
Changes
_alive_streaming_session_countto_streaming_session_count: sessions insession_controller.sessionsare always alive (removed on close), so "alive" adds no information.getattr(req, "session", None) is not None and req.session.streaminginrelease_kv_cachewith the existing_is_streaming(req)helper fromsession_aware_cache.