[Diffusion][CI] Fix nunchaku unit test broken by #22365#22560
Merged
Conversation
Mock maybe_download_model in test_resolve_transformer_quant_load_spec_keeps_nunchaku_hook to prevent it from trying to download a fake local path as an HF repo. #22365 added _resolve_quant_config_from_transformer_override which calls maybe_download_model on the transformer_weights_path, but the test uses a non-existent /tmp path that fails HF Hub validation.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/rerun-stage multimodal-gen-unit-test |
1 similar comment
Collaborator
Author
|
/rerun-stage multimodal-gen-unit-test |
Contributor
|
❌ Stage NVIDIA stages:
AMD stages:
Other stages will be added soon. For now, use |
1 similar comment
Contributor
|
❌ Stage NVIDIA stages:
AMD stages:
Other stages will be added soon. For now, use |
Collaborator
Author
yhyang201
approved these changes
Apr 11, 2026
pyc96
pushed a commit
to pyc96/sglang
that referenced
this pull request
Apr 14, 2026
…gl-project#22560) Co-authored-by: Alison Shao <alison.shao@MacBook-Pro-D2W773R9CD.local>
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
…gl-project#22560) Co-authored-by: Alison Shao <alison.shao@MacBook-Pro-D2W773R9CD.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maybe_download_modelintest_resolve_transformer_quant_load_spec_keeps_nunchaku_hookto prevent it from trying to download a fake local path (/tmp/svdq-int4_r32.safetensors) as an HF repo_resolve_quant_config_from_transformer_overridewhich callsmaybe_download_modelon the transformer weights path, but the test uses a non-existent/tmppath that fails HF Hub validationTest plan
multimodal-gen-unit-testCI job passes