[Spec][Ngram] Return token counts in list_external_corpora API#22471
Merged
hnyls2002 merged 3 commits intosgl-project:mainfrom Apr 11, 2026
Merged
[Spec][Ngram] Return token counts in list_external_corpora API#22471hnyls2002 merged 3 commits intosgl-project:mainfrom
hnyls2002 merged 3 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Replace corpus_ids list with corpus_token_counts dict (corpus_id -> token_count) in the list corpora response. This exposes per-corpus token counts from the SuffixAutomaton's pos_ counter through the full stack: C++ -> FFI -> Python -> HTTP. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
b79375f to
adf4a03
Compare
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/rerun-test registered/unit/spec/test_ngram_corpus.py |
Contributor
|
✅ |
Collaborator
Author
|
/rerun-test registered/unit/spec/test_ngram_corpus.py |
Contributor
|
✅ |
Collaborator
Author
|
/rerun-test test/registered/spec/test_ngram_speculative_decoding.py |
Contributor
|
✅ |
19 tasks
Collaborator
Author
|
/tag-and-rerun-ci |
…or FFI encoding Sync TokenizerManager with renamed corpus_token_counts field to prevent AttributeError, and switch FFI delimiter from comma to tab so corpus IDs containing commas are not misparsed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
/rerun-test registered/unit/spec/test_ngram_corpus.py |
Contributor
|
✅ |
pyc96
pushed a commit
to pyc96/sglang
that referenced
this pull request
Apr 14, 2026
…roject#22471) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of the Ngram series #21052
Admin will manage the external corpora themselves, we need to give them more insights into their corpora (token counts of each corpus)
Modifications
Replace
corpus_idslist withcorpus_token_counts dict(corpus_id->token_count) in the list corpora response. This exposes per-corpus token counts from the SuffixAutomaton'spos_counter through the full stack: C++ -> FFI -> Python -> HTTP.Accuracy Tests
N/A
Speed Tests and Profiling
N/A
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci