Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the AITER_COMMIT_DEFAULT environment variable to a specific commit hash and refactors the aiter installation in the ROCm Dockerfile to use a requirements.txt file. Feedback suggests using python3 -m pip install --no-cache-dir to optimize the Docker image size and ensure the correct Python interpreter is used.
| && git checkout ${AITER_COMMIT} \ | ||
| && git submodule update --init --recursive | ||
| && git submodule update --init --recursive \ | ||
| && pip install -r requirements.txt |
There was a problem hiding this comment.
It is recommended to use python3 -m pip install --no-cache-dir when installing dependencies in a Dockerfile. This ensures the correct Python interpreter is used and helps keep the image size smaller by not storing the pip cache. Additionally, please verify that psutil and pybind11 are included in the requirements.txt of the new Aiter version, as they were previously explicitly installed as build-time dependencies for the setup.py process.
&& python3 -m pip install --no-cache-dir -r requirements.txt
Motivation
Remove the hardcode installation of flydsl and upgrade aiter.
Modifications
Accuracy Tests
Test releases passed
https://github.com/sgl-project/sglang/actions/runs/23741801224
https://github.com/sgl-project/sglang/actions/runs/23741796361
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci