Skip to content

Release mm features on session close and support multiple /rerun-ut specs#21501

Merged
hnyls2002 merged 2 commits intomainfrom
lsyin/fix-session-mm-cleanup
Mar 27, 2026
Merged

Release mm features on session close and support multiple /rerun-ut specs#21501
hnyls2002 merged 2 commits intomainfrom
lsyin/fix-session-mm-cleanup

Conversation

@hnyls2002
Copy link
Copy Markdown
Collaborator

@hnyls2002 hnyls2002 commented Mar 27, 2026

Summary

Session mm cleanup (follow-up to #21269):

  • Release multimodal feature tensors when a session closes — session reqs skip the normal cleanup path, causing a memory leak
  • Add defensive clamp + warning for BOS offset adjustment edge case
  • Extract MultimodalInputs.release_features() to unify 3 inline cleanup patterns

/rerun-ut multi-spec support:

  • /rerun-ut test_a.py test_b.py test_c.py now dispatches all three and posts a single consolidated comment with workflow links

Test plan

  • Existing TestSessionControlVision in stage-b-test-1-gpu-large covers session + mm path
  • /rerun-ut change is CI infra only — test by posting a multi-spec comment on this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@hnyls2002 hnyls2002 changed the title Release mm features on session close and harden BOS offset adjustment Release mm features on session close and support multiple /rerun-ut specs Mar 27, 2026
@hnyls2002
Copy link
Copy Markdown
Collaborator Author

/rerun-ut test_session_control.py test_streaming_session.py test_session_latency.py

@github-actions
Copy link
Copy Markdown
Contributor

1-gpu-h100: View workflow run

cd test/ && python3 registered/sessions/test_session_control.py

1-gpu-h100: View workflow run

cd test/ && python3 registered/sessions/test_streaming_session.py

1-gpu-h100: View workflow run

cd test/ && python3 registered/sessions/test_session_latency.py

@hnyls2002
Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

@hnyls2002 hnyls2002 merged commit e1ee68d into main Mar 27, 2026
80 of 101 checks passed
@hnyls2002 hnyls2002 deleted the lsyin/fix-session-mm-cleanup branch March 27, 2026 01:31
satyamk7054 pushed a commit to satyamk7054/sglang that referenced this pull request Apr 3, 2026
JustinTong0323 pushed a commit to JustinTong0323/sglang that referenced this pull request Apr 7, 2026
yhyang201 pushed a commit to yhyang201/sglang that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant