Fix MxInt4 MoE returning wrong output variable#21348
Merged
ispobock merged 1 commit intosgl-project:mainfrom Mar 26, 2026
Merged
Fix MxInt4 MoE returning wrong output variable#21348ispobock merged 1 commit intosgl-project:mainfrom
ispobock merged 1 commit intosgl-project:mainfrom
Conversation
`trtllm_mxint4_block_scale_moe` writes into the `symm_output` buffer passed via the `output=` kwarg, but the return value was being captured into a separate `output` variable and returned instead of `symm_output`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
/tag-and-rerun-ci |
ispobock
approved these changes
Mar 25, 2026
satyamk7054
pushed a commit
to satyamk7054/sglang
that referenced
this pull request
Apr 3, 2026
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 7, 2026
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trtllm_mxint4_block_scale_moewrites results into thesymm_outputbuffer passed via theoutput=kwarg. The return value is a list which CombinedOutput doesnt expect