Skip to content

Split pr-test.yml: extract sgl-kernel, jit-kernel, and multimodal-gen tests into separate workflow files#21219

Merged
merrymercy merged 5 commits intomainfrom
lianmin/split-workflow
Mar 23, 2026
Merged

Split pr-test.yml: extract sgl-kernel, jit-kernel, and multimodal-gen tests into separate workflow files#21219
merrymercy merged 5 commits intomainfrom
lianmin/split-workflow

Conversation

@merrymercy
Copy link
Copy Markdown
Contributor

Summary

  • Extract sgl-kernel-unit-test, sgl-kernel-mla-test, sgl-kernel-benchmark-test, sgl-kernel-b200-test, and cuda13-kernel-smoke-test into pr-test-sgl-kernel.yml
  • Extract jit-kernel-unit-test, jit-kernel-unit-test-nightly, and jit-kernel-benchmark-test into pr-test-jit-kernel.yml
  • Extract multimodal-gen-test-1-gpu, multimodal-gen-test-2-gpu, and multimodal-gen-unit-test into pr-test-multimodal-gen.yml
  • Replace extracted jobs in pr-test.yml with workflow_call callers that preserve all dependency chains, conditions, and input/output relationships
  • Update pr-test-finish needs list and change detection filters to include the new workflow files

Pure code move — no functional changes.

Test plan

  • Verify YAML syntax passes (confirmed locally via yaml.safe_load)
  • Verify pre-commit hooks pass (confirmed: check yaml, codespell, etc.)
  • Confirm CI triggers correctly on a test PR with kernel/jit/multimodal changes

Made with Cursor

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the Multi-modal multi-modal language model label Mar 23, 2026
@merrymercy
Copy link
Copy Markdown
Contributor Author

/tag-and-rerun-ci

Comment thread .github/workflows/pr-test.yml
Comment thread .github/workflows/pr-test.yml
Comment thread .github/workflows/pr-test-jit-kernel.yml
Comment thread .github/workflows/pr-test-jit-kernel.yml
… tests into separate workflow files

Move test job definitions into reusable workflow_call files to reduce
the size of pr-test.yml. No functional changes — all dependency chains,
conditions, and inputs are preserved through the callers.

Made-with: Cursor
…ent env inheritance

- Add pr-test-sgl-kernel.yml to sgl_kernel change detection (dorny + API)
- Add sgl-kernel-build-wheels-arm to pr-test-finish needs list
- Add comments explaining that workflow-level env is NOT inherited from
  caller in reusable workflows, and github context IS inherited

Made-with: Cursor
…nheritance

Temporarily removes the env block and adds a debug step to verify
whether workflow-level env vars propagate from caller to called workflow.

Made-with: Cursor
CI test confirmed: caller workflow-level env vars do NOT propagate to
called workflows (3 of 4 showed UNSET). SGLANG_JIT_DEEPGEMM_FAST_WARMUP
was set from the runner's system environment, not the caller.

Made-with: Cursor
@merrymercy merrymercy force-pushed the lianmin/split-workflow branch from 36aeb93 to 2714da4 Compare March 23, 2026 17:51
@merrymercy merrymercy merged commit 4779755 into main Mar 23, 2026
58 of 65 checks passed
@merrymercy merrymercy deleted the lianmin/split-workflow branch March 23, 2026 20:17
adityavaid pushed a commit to adityavaid/sglang that referenced this pull request Mar 24, 2026
adityavaid pushed a commit to adityavaid/sglang that referenced this pull request Mar 24, 2026
0-693 pushed a commit to 0-693/sglang that referenced this pull request Mar 25, 2026
JustinTong0323 pushed a commit to JustinTong0323/sglang that referenced this pull request Apr 7, 2026
yhyang201 pushed a commit to yhyang201/sglang that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Multi-modal multi-modal language model run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant