docs: improve CI and testing documentation#21202
Conversation
Use register_fake_if_exists for sgl_kernel ops in fp8_kernel.py and fp8_utils.py, and replace the simple MagicMock stub in test_serving_embedding.py with a MetaPathFinder that properly handles all sgl_kernel.* submodule imports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the clarity and structure of the project's continuous integration and testing documentation. It introduces a comprehensive overview of the CI pipeline, test organization, and local execution instructions, making it easier for developers to understand and contribute to the testing framework. Alongside these documentation improvements, the PR also refactors various test-related scripts and removes obsolete utilities, contributing to a cleaner and more maintainable codebase. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly improves the documentation for the CI and testing systems, making it much clearer and more comprehensive for developers. The refactoring of the test infrastructure, including the move to a unified registry-based system, the consolidation of test runners, and more robust mocking for CPU-only tests, are all excellent changes that enhance maintainability and reliability. I've found one issue in the updated testing documentation that could cause CI to misreport test results, which I've detailed in a specific comment.
- Expand test/README.md with per-commit CUDA/CPU/AMD suite tables and guidance for choosing a suite; clarify est_time is in seconds. - Add stage-b-test-4-gpu-b200 to CUDA PER_COMMIT_SUITES and reorder entries to match documentation. Made-with: Cursor
|
/tag-and-rerun-ci |
- hisparse_memory_pool: import sgl_kernel.kvcacheio only when is_cuda or is_hip - write-sglang-test SKILL: link test/README.md, clarify GPU suite descriptions Made-with: Cursor
….toml Pin torchaudio==2.10.0+xpu in the Dockerfile pip install step to prevent a newer version (2.11.0+xpu) from being installed, which causes a version mismatch when pip install later resolves pyproject_xpu.toml dependencies. Made-with: Cursor
pytest.main() returns an exit code but does not exit the process, causing CI to misreport test failures. Wrap all bare pytest.main() calls in sys.exit() and add import sys where missing. Also fix the documentation in test/README.md and skill files. Made-with: Cursor
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
This PR is primarily focused on improving documentation for CI and tests: clearer guidance in
test/README.md, small doc/index and root README touch-ups, and related workflow readability updates where test suites are named or described.Additional changes (supporting / cleanup)
scripts/ci/amd/.Reviewers: the largest user-facing doc delta is
test/README.md; start there for the testing/CI story.Made with Cursor