[SKILL] fix(bench): Support model-specific DenoisingStage variants in…#21137
[SKILL] fix(bench): Support model-specific DenoisingStage variants in…#21137
Conversation
… latency parsing fix(bench): Support model-specific DenoisingStage variants in latency parsing
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the benchmarking script by making its latency parsing more flexible. It updates the logic for identifying denoising stages to accommodate various model-specific implementations, thereby improving the accuracy and compatibility of latency measurements across different diffusion models. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request extends the latency parsing logic to support model-specific variants of DenoisingStage, which is a good improvement for flexibility. I've added one suggestion to make the implementation more robust by handling cases where multiple matching stages might exist in the performance data.
| if ( | ||
| step.get("name") == "DenoisingStage" | ||
| isinstance(step_name, str) | ||
| and "DenoisingStage" in step_name | ||
| and step.get("duration_ms") is not None | ||
| ): | ||
| denoise_latency_s = float(step["duration_ms"]) / 1000.0 |
There was a problem hiding this comment.
The current implementation iterates through all steps and will overwrite denoise_latency_s if multiple steps contain 'DenoisingStage' in their name. This could lead to incorrect latency reporting if, for example, there are multiple denoising-related stages. To ensure you capture the latency for the first relevant stage found and to improve efficiency, consider breaking out of the loop once a match is found.
| if ( | |
| step.get("name") == "DenoisingStage" | |
| isinstance(step_name, str) | |
| and "DenoisingStage" in step_name | |
| and step.get("duration_ms") is not None | |
| ): | |
| denoise_latency_s = float(step["duration_ms"]) / 1000.0 | |
| if ( | |
| isinstance(step_name, str) | |
| and "DenoisingStage" in step_name | |
| and step.get("duration_ms") is not None | |
| ): | |
| denoise_latency_s = float(step["duration_ms"]) / 1000.0 | |
| break |
|
/tag-and-rerun-ci |
… latency parsing
fix(bench): Support model-specific DenoisingStage variants in latency parsing
Motivation
Extend the denoise latency extraction logic to accept model-specific variants of
DenoisingStage(e.g.,MOVADenoisingStage,HeliosChunkedDenoisingStage) in addition to the canonical name.Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci