[HiCache] Check in-flight async ops in is_fully_idle() before attach/detach#20746
Merged
[HiCache] Check in-flight async ops in is_fully_idle() before attach/detach#20746
is_fully_idle() before attach/detach#20746Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
Collaborator
Author
|
/rerun-ut test_hicache_storage_runtime_attach_detach.py |
Collaborator
Author
|
/rerun-ut test_hicache_storage_mooncake_backend.py |
Contributor
|
✅ Triggered |
Contributor
|
✅ Triggered |
Contributor
1 similar comment
Contributor
The new is_fully_idle() HiCache check may cause flush_cache to fail when async ops (GPU↔Host↔L3) are still in-flight after requests complete. Add a shared retry helper and use it in all HiCache tests.
Wangzheee
pushed a commit
to Wangzheee/sglang
that referenced
this pull request
Mar 21, 2026
5 tasks
0-693
pushed a commit
to 0-693/sglang
that referenced
this pull request
Mar 25, 2026
dutsc
pushed a commit
to dutsc/sglang
that referenced
this pull request
Mar 30, 2026
KHAEntertainment
pushed a commit
to Clarit-AI/Engram
that referenced
this pull request
Mar 31, 2026
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 7, 2026
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ongoing_write_through,ongoing_load_back,ongoing_prefetch,ongoing_backupinis_fully_idle()so attach/detach/flush_cache wait for all GPU↔Host↔L3 async ops to drainnot for_health_checkto avoid blocking health check probes with background cache I/Ocheck_hicache_events()runs when idle, butis_fully_idle()still didn't account for in-flight HiCache ops, allowing unsafe detach while GPU→Host writes are pending