Add check to provide hicache-storage-backend when enabling kv caching on Decode Side in PD Disaggregation#20732
Merged
ShangmingCai merged 2 commits intosgl-project:mainfrom Mar 17, 2026
Conversation
… on decode side Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Closed
5 tasks
hzh0425
approved these changes
Mar 17, 2026
Wangzheee
pushed a commit
to Wangzheee/sglang
that referenced
this pull request
Mar 21, 2026
… on Decode Side in PD Disaggregation (sgl-project#20732) Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
0-693
pushed a commit
to 0-693/sglang
that referenced
this pull request
Mar 25, 2026
… on Decode Side in PD Disaggregation (sgl-project#20732) Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 7, 2026
… on Decode Side in PD Disaggregation (sgl-project#20732) Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
… on Decode Side in PD Disaggregation (sgl-project#20732) Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--disaggregation-decode-enable-offload-kvcacheonly works whenhicache-storage-backendis provided. Adding sanity check in the ServerArgs to check this.PS: Follow-up to the PR #20677