Skip to content

Add check to provide hicache-storage-backend when enabling kv caching on Decode Side in PD Disaggregation#20732

Merged
ShangmingCai merged 2 commits intosgl-project:mainfrom
MMuzzammil1:muz/add-disagg-check
Mar 17, 2026
Merged

Add check to provide hicache-storage-backend when enabling kv caching on Decode Side in PD Disaggregation#20732
ShangmingCai merged 2 commits intosgl-project:mainfrom
MMuzzammil1:muz/add-disagg-check

Conversation

@MMuzzammil1
Copy link
Copy Markdown
Contributor

@MMuzzammil1 MMuzzammil1 commented Mar 17, 2026

--disaggregation-decode-enable-offload-kvcache only works when hicache-storage-backend is provided. Adding sanity check in the ServerArgs to check this.

PS: Follow-up to the PR #20677

… on decode side

Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@hzh0425 hzh0425 added the run-ci label Mar 17, 2026
Copy link
Copy Markdown
Collaborator

@ShangmingCai ShangmingCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShangmingCai ShangmingCai merged commit 855ec70 into sgl-project:main Mar 17, 2026
41 of 82 checks passed
Wangzheee pushed a commit to Wangzheee/sglang that referenced this pull request Mar 21, 2026
… on Decode Side in PD Disaggregation (sgl-project#20732)

Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
0-693 pushed a commit to 0-693/sglang that referenced this pull request Mar 25, 2026
… on Decode Side in PD Disaggregation (sgl-project#20732)

Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
JustinTong0323 pushed a commit to JustinTong0323/sglang that referenced this pull request Apr 7, 2026
… on Decode Side in PD Disaggregation (sgl-project#20732)

Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
yhyang201 pushed a commit to yhyang201/sglang that referenced this pull request Apr 22, 2026
… on Decode Side in PD Disaggregation (sgl-project#20732)

Signed-off-by: Mohd Muzzammil <me.muzzammil@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants