Skip to content

[AMD] diffusion refactor: move ROCM VAE optimization to Platform abstraction#20496

Merged
HaiShaw merged 2 commits intosgl-project:mainfrom
yctseng0211:refactor_aiter_vae
Mar 13, 2026
Merged

[AMD] diffusion refactor: move ROCM VAE optimization to Platform abstraction#20496
HaiShaw merged 2 commits intosgl-project:mainfrom
yctseng0211:refactor_aiter_vae

Conversation

@yctseng0211
Copy link
Copy Markdown
Collaborator

Motivation

Follows up on #20170 review feedback. Moves platform-specific AITer GroupNorm
replacement out of decoding.py into the Platform polymorphic pattern:

  • Register SGLANG_USE_ROCM_VAE in envs.py
  • Add optimize_vae() hook to Platform base class
  • Override in RocmPlatform with AITer GroupNorm replacement
  • Call from VAELoader at load time
  • Remove all platform-specific logic from decoding.py

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions Bot added amd diffusion SGLang Diffusion labels Mar 13, 2026
@HaiShaw
Copy link
Copy Markdown
Collaborator

HaiShaw commented Mar 13, 2026

/tag-and-rerun-ci

@HaiShaw HaiShaw merged commit c37ef7f into sgl-project:main Mar 13, 2026
126 of 139 checks passed
yhyang201 pushed a commit to yhyang201/sglang that referenced this pull request Mar 15, 2026
Wangzheee pushed a commit to Wangzheee/sglang that referenced this pull request Mar 21, 2026
0-693 pushed a commit to 0-693/sglang that referenced this pull request Mar 25, 2026
JustinTong0323 pushed a commit to JustinTong0323/sglang that referenced this pull request Apr 7, 2026
yhyang201 pushed a commit to yhyang201/sglang that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants