perf(qwen3_5): replace einops rearrange with torch.flatten in GatedDe…#20386
Merged
ispobock merged 2 commits intosgl-project:mainfrom Mar 12, 2026
Merged
perf(qwen3_5): replace einops rearrange with torch.flatten in GatedDe…#20386ispobock merged 2 commits intosgl-project:mainfrom
ispobock merged 2 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
/tag-and-rerun-ci |
zminglei
approved these changes
Mar 11, 2026
zminglei
reviewed
Mar 11, 2026
| core_attn_out = self.norm(core_attn_out, z) | ||
| core_attn_out = core_attn_out.reshape(z_shape_og) | ||
| core_attn_out = rearrange(core_attn_out, "... h d -> ... (h d)") | ||
| core_attn_out = core_attn_out.flatten(-2) |
Collaborator
There was a problem hiding this comment.
we can add a comment for the shape transfer here as "... h d -> ... (h d)" to keep the readability
Contributor
Author
|
/rerun-failed-ci |
…ltaNet Replace `rearrange(core_attn_out, '... h d -> ... (h d)')' with `core_attn_out.flatten(-2)` in Qwen3_5GatedDeltaNet.forward(). Removes the einops dependency from this model file, using a native PyTorch operation that is semantically equivalent and 2.67x faster (12.67us -> 4.74us avg per call, measured over 720 calls on H100).
c7ce97a to
2588b92
Compare
38 tasks
liubiyongge
pushed a commit
to liubiyongge/sglang
that referenced
this pull request
Mar 13, 2026
Wangzheee
pushed a commit
to Wangzheee/sglang
that referenced
this pull request
Mar 21, 2026
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 7, 2026
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
einops.rearrangeperforms Python-level string parsing and validation on every call. InQwen3_5GatedDeltaNet.forward(), the patternrearrange(x, "... h d -> ... (h d)")is a simple flatten of the last two dimensions — equivalent totorch.flatten(-2), which is a zero-copy view operation with no parsing overhead.This call runs on every forward pass through every GDN layer in the model, so the overhead accumulates significantly.
Changes
rearrange(core_attn_out, "... h d -> ... (h d)")withcore_attn_out.flatten(-2)inQwen3_5GatedDeltaNet.forward()from einops import rearrangeimportProfiling Results
Profiled on Qwen3.5-9B, H100 80GB, TP=1, CUDA graphs disabled, using
sglang.bench_servingwith torch profiler. Perfetto SQL queries filtered to onlyGatedDeltaNetancestor slices.Baseline (einops)
einops/einops.py(561): rearrangeOptimized (torch.flatten)
<built-in method flatten>aten::flattenSummary
Profiling Reproduction Commands
1. Launch server
export SGLANG_TORCH_PROFILER_DIR=/path/to/traces python -m sglang.launch_server \ --model-path Qwen/Qwen3.5-9B \ --port 30000 --tp 1 --disable-cuda-graph2. Run profiling benchmark
3. Perfetto SQL queries
Baseline (einops rearrange in GatedDeltaNet):
Optimized (flatten in GatedDeltaNet):
Correctness
flatten(-2)is semantically identical torearrange("... h d -> ... (h d)")— both merge the last two dimensions into one. No behavior change.Ran GSM8k to test performance and accuracy
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci