[Scheduler] Unify idle checks into is_fully_idle() and fix weight update test#20296
Merged
[Scheduler] Unify idle checks into is_fully_idle() and fix weight update test#20296
is_fully_idle() and fix weight update test#20296Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/rerun-ut test_update_weights_from_tensor.py |
Contributor
|
✅ Triggered |
Contributor
release_memory_occupation idle guard and fix test to use abort modeis_fully_idle() and fix weight update test
liubiyongge
pushed a commit
to liubiyongge/sglang
that referenced
this pull request
Mar 13, 2026
whybeyoung
pushed a commit
to whybeyoung/sglang
that referenced
this pull request
Mar 14, 2026
whybeyoung
added a commit
to whybeyoung/sglang
that referenced
this pull request
Mar 14, 2026
…weight update test (sgl-project#20296)" This reverts commit 6c4d35e.
Wangzheee
pushed a commit
to Wangzheee/sglang
that referenced
this pull request
Mar 21, 2026
KHAEntertainment
pushed a commit
to Clarit-AI/Engram
that referenced
this pull request
Mar 31, 2026
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 7, 2026
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_no_request(),_is_idle_for_hicache_storage_op(), and inline health-check logic into a singleis_fully_idle(for_health_check=False)release_memory_occupationandflush_cacheguards to useis_fully_idle()— now also checkschunked_req,dllm_manager,waiting_queue, andgrammar_queueBackground
_is_no_request()did not checkwaiting_queueorgrammar_queue, soflush_cachecould clear KV cache while retracted requests sat inwaiting_queue_is_idle_for_hicache_storage_op()was a superset of_is_no_request()but missedchunked_reqanddllm_managerFix
is_fully_idle()covers all batch-running state (includingchunked_req,dllm_manager, overlap, PP, disagg) plus all waiting queuesfor_health_check=Trueskips grammar queue and prefill inflight queue (they don't produce immediate batch results, so ongoing requests in other queues already carry health info)release_memory_occupationnow assertsis_fully_idle()instead of_is_no_request()test_update_weightsto usepause_generation("abort")which fully drains all requests before weight update (old "retract" mode left requests inwaiting_queue, incompatible with the stricter idle check)is_fully_idle()