[misc] add env for http keep alive timeout#19847
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the HTTP server's configurability by introducing an environment variable to control the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new environment variable SGLANG_TIMEOUT_KEEP_ALIVE to make the HTTP keep-alive timeout configurable. This was previously a hardcoded value. The change is well-implemented, and the default behavior is preserved. My feedback includes a suggestion to add a descriptive comment for the new environment variable to improve code clarity and maintain consistency with other environment variables in the file.
| SGLANG_WARMUP_TIMEOUT = EnvFloat(-1) # in seconds. If a warmup forward batch takes longer than this, the server will crash to prevent hanging. Recommend to increase warmup timeout to 1800 to accommodate some kernel JIT precache e.g. deep gemm | ||
|
|
||
| # HTTP Server | ||
| SGLANG_TIMEOUT_KEEP_ALIVE = EnvInt(5) |
There was a problem hiding this comment.
For consistency and clarity, it would be beneficial to add a comment explaining what this environment variable configures and its unit (seconds), similar to other variables in this file.
| SGLANG_TIMEOUT_KEEP_ALIVE = EnvInt(5) | |
| SGLANG_TIMEOUT_KEEP_ALIVE = EnvInt(5) # in seconds. The timeout for keeping the HTTP connection alive. |
|
/tag-and-rerun-ci |
Motivation
Default behavior is not changed. a longer keep alive time can make the tcp connection reusable.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci