Skip to content

Support return_logprob for spec v2 (overlap safe)#19801

Merged
hnyls2002 merged 10 commits intosgl-project:mainfrom
Qiaolin-Yu:spec_logprob
Mar 10, 2026
Merged

Support return_logprob for spec v2 (overlap safe)#19801
hnyls2002 merged 10 commits intosgl-project:mainfrom
Qiaolin-Yu:spec_logprob

Conversation

@Qiaolin-Yu
Copy link
Copy Markdown
Collaborator

@Qiaolin-Yu Qiaolin-Yu commented Mar 3, 2026

Motivation

Closes #19761 #17349

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@Qiaolin-Yu Qiaolin-Yu mentioned this pull request Mar 3, 2026
5 tasks
@Qiaolin-Yu
Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

@github-actions github-actions Bot added the run-ci label Mar 3, 2026
Qiaolin-Yu and others added 2 commits March 3, 2026 22:31
Co-authored-by: Ratish1 <ratish1501@gmail.com>
Co-authored-by: Ratish1 <formula733@gmail.com>
def get_top_logprobs(
logprobs: torch.Tensor,
top_logprobs_nums: List[int],
no_copy_to_cpu: bool = False,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great rename!

@Qiaolin-Yu Qiaolin-Yu changed the title Support return_logprob for spec v2 Support return_logprob for spec v2 [overlap safe] Mar 10, 2026
@Qiaolin-Yu Qiaolin-Yu changed the title Support return_logprob for spec v2 [overlap safe] Support return_logprob for spec v2 (overlap safe) Mar 10, 2026
@hnyls2002 hnyls2002 merged commit 09a118f into sgl-project:main Mar 10, 2026
219 of 234 checks passed
@Qiaolin-Yu Qiaolin-Yu deleted the spec_logprob branch March 10, 2026 22:44
liubiyongge pushed a commit to liubiyongge/sglang that referenced this pull request Mar 13, 2026
Co-authored-by: Ratish1 <ratish1501@gmail.com>
Co-authored-by: Ratish1 <formula733@gmail.com>
Co-authored-by: hnyls2002 <lsyincs@gmail.com>
Wangzheee pushed a commit to Wangzheee/sglang that referenced this pull request Mar 21, 2026
Co-authored-by: Ratish1 <ratish1501@gmail.com>
Co-authored-by: Ratish1 <formula733@gmail.com>
Co-authored-by: hnyls2002 <lsyincs@gmail.com>
JustinTong0323 pushed a commit to JustinTong0323/sglang that referenced this pull request Apr 7, 2026
Co-authored-by: Ratish1 <ratish1501@gmail.com>
Co-authored-by: Ratish1 <formula733@gmail.com>
Co-authored-by: hnyls2002 <lsyincs@gmail.com>
yhyang201 pushed a commit to yhyang201/sglang that referenced this pull request Apr 22, 2026
Co-authored-by: Ratish1 <ratish1501@gmail.com>
Co-authored-by: Ratish1 <formula733@gmail.com>
Co-authored-by: hnyls2002 <lsyincs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support logprobs for spec v2 (overlap-safe)

2 participants