Helios: Real Real-Time Long Video Generation Model#19782
Helios: Real Real-Time Long Video Generation Model#19782yhyang201 merged 7 commits intosgl-project:mainfrom
Conversation
- Restore fp8_utils.py and compressed_tensors_w4a4_mxint4_moe.py to main - Restore docs/diffusion/support_new_models.md to main - Remove Helios.md and add-new-diffusion-model.md skill
|
/tag-and-rerun-ci |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the SGLang framework by integrating the Helios video generation model family. It provides the foundational architecture for the Helios 3D Transformer, alongside comprehensive pipeline configurations tailored for different video generation stages, from basic Text-to-Video to advanced Pyramid Super-Resolution and Distilled models. A custom multi-stage scheduler and a sophisticated chunked denoising stage are introduced to efficiently handle the intricate requirements of high-quality video synthesis, including managing temporal dependencies and multi-resolution processing. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for the Helios model family, including its base, mid, and distilled variants. It introduces new configuration files, a model implementation for the Helios 3D transformer, a custom scheduler, and a new pipeline. The changes are extensive and well-structured. I've identified a couple of areas for improvement related to an unused function parameter and an incorrect type hint, which should be straightforward to address.
| hf_model_paths=[ | ||
| "BestWishYsh/Helios-Base", | ||
| ], | ||
| model_detectors=[ |
There was a problem hiding this comment.
do we really need this? I'm considering deprecating model_detectors these days
|
/rerun-failed-ci |
|
@mickqian all ci passed |
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci