Adjust reward model's score module and pooler module order for reducing computation#1956
Merged
merrymercy merged 9 commits intosgl-project:mainfrom Nov 8, 2024
Merged
Adjust reward model's score module and pooler module order for reducing computation#1956merrymercy merged 9 commits intosgl-project:mainfrom
merrymercy merged 9 commits intosgl-project:mainfrom
Conversation
merrymercy
reviewed
Nov 8, 2024
| return self.pooler(scores, forward_batch) | ||
| return EmbeddingPoolerOutput(scores) | ||
|
|
||
| def load_weights(self, weights: Iterable[Tuple[str, torch.Tensor]]): |
Contributor
There was a problem hiding this comment.
can you also simplify the weight loader of LlamaForSequenceClassification?
Contributor
|
Can you fix the lint error? |
merrymercy
reviewed
Nov 8, 2024
merrymercy
reviewed
Nov 8, 2024
merrymercy
approved these changes
Nov 8, 2024
Contributor
|
@aqweteddy Thanks for the contribution. It is merged. |
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
poolerandscoremodules inclass LlamaForSequenceClassificationandclass Gemma2ForSequenceClassificationto reduce computation.Checklist