Skip to content

[Diffusion] [NPU] [Doc] Add NPU documentation for sglang-diffusion#18894

Merged
ping1jing2 merged 2 commits intosgl-project:mainfrom
Makcum888e:diffusion_doc
Feb 17, 2026
Merged

[Diffusion] [NPU] [Doc] Add NPU documentation for sglang-diffusion#18894
ping1jing2 merged 2 commits intosgl-project:mainfrom
Makcum888e:diffusion_doc

Conversation

@Makcum888e
Copy link
Copy Markdown
Contributor

@Makcum888e Makcum888e commented Feb 16, 2026

Motivation

Add NPU diffusion support to documents

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Feb 16, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Feb 16, 2026

Summary of Changes

Hello @Makcum888e, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the SGLang Diffusion documentation by integrating support for Ascend NPU. It updates the platform compatibility information, provides specific installation guidance for NPU users, and clarifies how attention backends function on NPU hardware, ensuring comprehensive documentation for this new platform.

Highlights

  • NPU Platform Support: Added Ascend NPU (A2, A3) to the list of supported multi-platforms for SGLang Diffusion, expanding hardware compatibility.
  • NPU Installation Guide: Introduced a dedicated section in the installation documentation for Ascend NPU, directing users to a separate, detailed guide.
  • Attention Backend Compatibility: Updated the attention backend documentation to specify that NPU platforms always utilize PyTorch SDPA and extended the platform support matrix to include NPU compatibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs/diffusion/index.md
    • Updated the 'Multi-Platform' feature description to include Ascend NPU (A2, A3) devices.
  • docs/diffusion/installation.md
    • Added a new top-level section 'Platform-Specific: Ascend NPU' with a link to a detailed installation guide.
  • docs/diffusion/performance/attention_backends.md
    • Included NPU in the list of platforms that default to PyTorch SDPA for attention.
    • Expanded the 'Platform support matrix' table to add a dedicated column for NPU compatibility across various backends.
Activity
  • The author has marked the 'Update documentation' checklist item as complete in the pull request description.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for Ascend NPU support to sglang-diffusion. The changes include updating the main page to list NPU as a supported platform, adding an NPU-specific installation section with a link to the detailed guide, and updating the attention backends documentation to reflect NPU's capabilities. The changes are straightforward and help integrate NPU support into the project's documentation. I have one minor suggestion to improve the clarity of the installation instructions.

Comment thread docs/diffusion/installation.md Outdated
@Makcum888e @gemini-code-assist
Update docs/diffusion/installation.md
30f42ed 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ping1jing2 ping1jing2 merged commit 14c95d2 into sgl-project:main Feb 17, 2026
43 checks passed
@ping1jing2 ping1jing2 self-assigned this Feb 17, 2026
@ping1jing2 ping1jing2 mentioned this pull request Feb 18, 2026
Open
89 tasks
magicYang1573 pushed a commit to magicYang1573/sglang that referenced this pull request Mar 9, 2026
@Makcum888e @gemini-code-assist
[Diffusion] [NPU] [Doc] Add NPU documentation for sglang-diffusion (s…
bf419fa 
…gl-project#18894)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Wangzheee pushed a commit to Wangzheee/sglang that referenced this pull request Mar 21, 2026
@Makcum888e @gemini-code-assist @Wangzheee
[Diffusion] [NPU] [Doc] Add NPU documentation for sglang-diffusion (s…
9c9d8ea 
…gl-project#18894)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Makcum888e Makcum888e deleted the diffusion_doc branch April 17, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ping1jing2 ping1jing2 ping1jing2 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ping1jing2 ping1jing2

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Makcum888e @ping1jing2