Build ROCm7.2 Image with latest AITER v0.1.10.post3#18741
Build ROCm7.2 Image with latest AITER v0.1.10.post3#18741HaiShaw merged 1 commit intosgl-project:mainfrom
Conversation
Summary of ChangesHello @HaiShaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the ROCm7.2 Docker image configuration to integrate the latest AITER version, 'v0.1.10.post3'. This ensures that all future builds of the ROCm7.2 image will leverage the most recent AITER features and bug fixes, and explicitly enables the AITER build process for the 'gfx950' architecture. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the AITER version to v0.1.10.post3 and enables the AITER build for the gfx950 architecture in the ROCm 7.2 Dockerfile. The changes are straightforward and align with the goal of using the latest AITER version. I've provided a suggestion to improve the maintainability of the Dockerfile by using a build argument for the version string, which would simplify future updates. I also pointed out a potentially obsolete hot patch that might need to be removed.
| ENV BUILD_AITER_ALL="1" | ||
| ENV BUILD_MOONCAKE="1" | ||
| ENV AITER_COMMIT="v0.1.10.post2" | ||
| ENV AITER_COMMIT="v0.1.10.post3" |
There was a problem hiding this comment.
I have a couple of suggestions regarding this version update:
-
Maintainability: The
AITER_COMMITversion is hardcoded in multiple places. To improve maintainability, consider defining it as a build argument at the top of the file and reusing it in each stage. This would centralize the version and simplify future updates.
For example:- At the top of the Dockerfile, add:
ARG AITER_COMMIT_VERSION="v0.1.10.post3" - In each build stage (e.g., after
FROM ... AS gfx942), add:ARG AITER_COMMIT_VERSION - Then, replace this line and other similar lines with:
ENV AITER_COMMIT=$AITER_COMMIT_VERSION
- At the top of the Dockerfile, add:
-
Potentially Obsolete Patch: The hot patch for AITER on lines 139-149 is commented as being for
v0.1.10.post1. Since you're updating tov0.1.10.post3, this patch might be obsolete. If the issue it addresses is fixed in the new version, removing the patch would be cleaner and safer.
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci