Skip to content

chore: bump mooncake version to 0.3.9#18316

Merged
ShangmingCai merged 2 commits intomainfrom
bump_mc
Feb 7, 2026
Merged

chore: bump mooncake version to 0.3.9#18316
ShangmingCai merged 2 commits intomainfrom
bump_mc

Conversation

@ShangmingCai
Copy link
Copy Markdown
Collaborator

Motivation

This PR will unblock #17810

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

Signed-off-by: Shangming Cai <csmthu@gmail.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ShangmingCai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the version of the mooncake and mooncake-transfer-engine dependencies to 0.3.9. This change is crucial for unblocking another related pull request, ensuring that the build environment and continuous integration processes utilize the latest compatible version of the library.

Highlights

  • Dependency Version Bump: The MOONCAKE_VERSION argument in the Dockerfile has been updated from 0.3.8.post1 to 0.3.9.
  • CI Script Update: The mooncake-transfer-engine package version in the CI dependency installation script (ci_install_dependency.sh) has been updated to 0.3.9.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docker/Dockerfile
    • Updated the MOONCAKE_VERSION ARG from 0.3.8.post1 to 0.3.9.
  • scripts/ci/cuda/ci_install_dependency.sh
    • Changed the mooncake-transfer-engine package version in the pip install command from 0.3.8.post1 to 0.3.9.
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ShangmingCai
Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mooncake dependency version to 0.3.9 in the Dockerfile and a CI installation script. The changes are consistent and straightforward. I've added one suggestion to the CI script to define the version as a variable for better maintainability, which aligns with how other dependencies are handled in the same file. Otherwise, the changes look good.

Comment thread scripts/ci/cuda/ci_install_dependency.sh
@ShangmingCai
Copy link
Copy Markdown
Collaborator Author

ShangmingCai commented Feb 6, 2026

image The timeout test might be related to mooncake-ep, let me rerun the test.

@ShangmingCai
Copy link
Copy Markdown
Collaborator Author

/rerun-stage stage-c-test-deepep-4-gpu

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2026

✅ Triggered stage-c-test-deepep-4-gpu to run independently (skipping dependencies).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2026

🔗 View workflow run

@ShangmingCai
Copy link
Copy Markdown
Collaborator Author

update:
Uploading image.png…

@ShangmingCai ShangmingCai merged commit 52401be into main Feb 7, 2026
92 of 123 checks passed
@ShangmingCai ShangmingCai deleted the bump_mc branch February 7, 2026 09:30
charlesHsuGG pushed a commit to charlesHsuGG/sglang that referenced this pull request Feb 9, 2026
Signed-off-by: Shangming Cai <csmthu@gmail.com>
Johnsonms pushed a commit to Johnsonms/sglang that referenced this pull request Feb 14, 2026
Signed-off-by: Shangming Cai <csmthu@gmail.com>
magicYang1573 pushed a commit to magicYang1573/sglang that referenced this pull request Mar 9, 2026
Signed-off-by: Shangming Cai <csmthu@gmail.com>
Wangzheee pushed a commit to Wangzheee/sglang that referenced this pull request Mar 21, 2026
Signed-off-by: Shangming Cai <csmthu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant