[Docker] Install cudnn==9.16 for cuda 13 image to avoid check error#17668
[Docker] Install cudnn==9.16 for cuda 13 image to avoid check error#17668
Conversation
Summary of ChangesHello @Fridge003, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical runtime error related to PyTorch 2.9.1 and CuDNN compatibility when using CUDA 13. By explicitly installing the correct CuDNN version in the Docker image for CUDA 13, the change ensures that applications can run without encountering the reported compatibility issue. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a runtime error related to PyTorch and CuDNN compatibility for CUDA 13 by adding the installation of nvidia-cudnn-cu13. The change is straightforward and necessary. I've included a suggestion to group the pip install commands for better maintainability and a minor build performance improvement, consistent with other parts of the Dockerfile.
| python3 -m pip install nvidia-nccl-cu13==2.28.3 --force-reinstall --no-deps ; \ | ||
| python3 -m pip install nvidia-cudnn-cu13==9.16.0.29 --force-reinstall --no-deps ; \ | ||
| python3 -m pip install nvidia-cublas==13.1.0.3 --force-reinstall --no-deps ; \ | ||
| python3 -m pip install nixl-cu13 --no-deps ; \ | ||
| python3 -m pip install cuda-python==13.1.1 ; \ |
There was a problem hiding this comment.
For better maintainability and to slightly improve build performance by reducing the number of pip processes, consider grouping these pip install commands based on their options. This is also more consistent with how packages are installed elsewhere in this Dockerfile.
python3 -m pip install --force-reinstall --no-deps \
nvidia-nccl-cu13==2.28.3 \
nvidia-cudnn-cu13==9.16.0.29 \
nvidia-cublas==13.1.0.3 ; \
python3 -m pip install nixl-cu13 --no-deps ; \
python3 -m pip install cuda-python==13.1.1 ; \
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci