Skip to content

Update mamba env setting#17566

Merged
ispobock merged 1 commit intomainfrom
env-adjust
Jan 23, 2026
Merged

Update mamba env setting#17566
ispobock merged 1 commit intomainfrom
env-adjust

Conversation

@ispobock
Copy link
Copy Markdown
Collaborator

@ispobock ispobock commented Jan 22, 2026

Motivation

use environ to set, get, override env

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Jan 22, 2026

Summary of Changes

Hello @ispobock, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the handling of environment variables across the SGLang project by migrating from direct os.environ calls to a dedicated envs object. This change enhances the robustness and maintainability of environment-dependent configurations, particularly for Mamba models, and improves test isolation by providing a controlled mechanism for overriding settings. It also adds a new environment variable to manage Outlines disk cache behavior.

Highlights

  • Environment Variable Management Refactor: Replaced direct usage of os.environ with a new envs object for setting and retrieving environment variables, centralizing their management.
  • New Environment Variable: Introduced SGLANG_DISABLE_OUTLINES_DISK_CACHE as a new configurable environment variable within the envs system.
  • Mamba Configuration Update: Updated Mamba-related environment variables (SGLANG_MAMBA_CONV_DTYPE, SGLANG_MAMBA_SSM_DTYPE) to use the new envs object for consistent access and override capabilities.
  • Improved Test Isolation: Modified unit tests to leverage the envs.override() context manager, ensuring that environment variable changes made during tests are localized and do not affect other tests or global state.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@ispobock
Copy link
Copy Markdown
Collaborator Author

ispobock commented Jan 22, 2026

/tag-and-rerun-ci

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request refactors environment variable management by transitioning from direct os.environ calls to a centralized envs object utilizing EnvField and override context managers. This change is consistently applied across the codebase, including core logic and test files. This approach significantly enhances maintainability, testability, and clarity by ensuring that environment variable settings are properly scoped and automatically cleaned up after use. This is a robust improvement to the system's architecture.

@ispobock ispobock mentioned this pull request Jan 22, 2026
Merged
@ispobock ispobock merged commit 7ace64d into main Jan 23, 2026
259 of 279 checks passed
@ispobock ispobock deleted the env-adjust branch January 23, 2026 03:02
Johnsonms pushed a commit to Johnsonms/sglang that referenced this pull request Feb 14, 2026
@ispobock @Johnsonms
Update mamba env setting (sgl-project#17566)
b7b053e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yizhang2077 yizhang2077 yizhang2077 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run-ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ispobock @yizhang2077