fix: nightly wheel naming for non-post versions#17538
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
https://github.com/sgl-project/whl/releases/tag/nightly-2026-01-22-232982a0d Why do we have 5 files? Look at other nightly releases we only have 3 files |
These are from previous workflow trials when I was attempting to fix this - I used the same commit to reproduce the bug so this commit's nightly wheel has more versions from my tests; once merged each nightly wheel will only have three files |
|
|
||
| # Build wheel - setuptools-scm automatically generates version from git tags | ||
| # Parse git describe output to detect exact tag builds (distance=0) | ||
| DESC=$(git describe --tags --long --match 'v*' 2>/dev/null || echo 'v0.0.0-0-g0000000') |
There was a problem hiding this comment.
We need to keep the git describe command aligned:
https://github.com/sgl-project/sglang/blob/main/python/pyproject.toml#L167
The git describe command here will generate 0.5.6.post2 tag rather than 0.5.7
There was a problem hiding this comment.
Thank you for the comment! Fixed~
Motivation
When building nightly wheels at an exact tag commit (Distance=0 from tag), setuptools-scm generates a version without a dev number (eg. 0.5.7 instead of 0.5.7.devN). This results in wheel filenames like sglang-0.5.7-py3-none-any.whl that are not unique, causing new builds to overwrite previous wheels with the same base version.
Modifications
Modified the nightly wheel build workflow to detect when building at an exact tag (distance=0) and force a dev0 version using the SETUPTOOLS_SCM_PRETEND_VERSION environment variable. This ensures every nightly wheel has a unique filename.
Accuracy Tests
https://github.com/sgl-project/whl/releases/tag/nightly-2026-01-24-ebafc5cf5
Benchmarking and Profiling
n/a
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci