[NPU]bugfix: fix for dsv3.2 and dsvl2#17007
Merged
iforgetmyname merged 7 commits intosgl-project:mainfrom Jan 23, 2026
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
7bd6926 to
a71eb70
Compare
a71eb70 to
eb449e9
Compare
eb449e9 to
34d02be
Compare
Collaborator
|
please update the description |
Contributor
|
please update the tests |
| mla_event = torch.npu.Event() | ||
| mla_event.record() | ||
| with torch.npu.stream(m.alt_stream): | ||
| torch.npu.current_stream().wait_event(mla_event) |
There was a problem hiding this comment.
mla_event here is meaningless: main stream record event and then alt_stream wait this event ?
| k_nope = m.kv_a_layernorm(k_nope).unsqueeze(1) | ||
| torch.npu.current_stream().wait_event(q_event) | ||
| k_nope = m.kv_a_layernorm(k_nope) | ||
| if q_event is not None: |
There was a problem hiding this comment.
if m.alt_stream is not None:
current_stream.wait_stream(m.alt_stream)
Collaborator
|
/tag-and-rerun-ci |
Johnsonms
pushed a commit
to Johnsonms/sglang
that referenced
this pull request
Feb 14, 2026
Co-authored-by: Hexq0210 <893781835@qq.com> Co-authored-by: liupeng374 <782420244@qq.com> Co-authored-by: cy <chenyang08056032@163.com>
Todobe
pushed a commit
to Todobe/sgl-sglang
that referenced
this pull request
Mar 3, 2026
Co-authored-by: Hexq0210 <893781835@qq.com> Co-authored-by: liupeng374 <782420244@qq.com> Co-authored-by: cy <chenyang08056032@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
1、There are some bugs for DS-Vl2 on rotary_embedding
2、DSV32 is not compatible with the scenario where m.alt_stream is not None.
Modifications
1、Fix the ds-v12 rotary_embedding bug and add a branch to the RotaryEmebedding class.
2、The fix ds-v32 is compatible with the scenario where m.alt_stream is empty.
Accuracy Tests
Both (dsvl2/dsv3.2) models are covered by CI
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci